--changedFilesWithAncestor #4070
Conversation
aaronabramov
force-pushed
the
with_ancestor
branch
from
2702094
to
5a48553
Compare
Codecov Report
@@ Coverage Diff @@
## master #4070 +/- ##
==========================================
- Coverage 60.41% 60.41% -0.01%
==========================================
Files 196 196
Lines 6766 6768 +2
Branches 6 6
==========================================
+ Hits 4088 4089 +1
- Misses 2675 2676 +1
Partials 3 3
Continue to review full report at Codecov.
|
| @@ -19,6 +19,11 @@ const adapter: SCMAdapter = { | |||
| cwd: string, | |||
| options?: Options, | |||
| ): Promise<Array<Path>> => { | |||
| if (options && options.withAncestor) { | |||
| throw new Error( | |||
| '`changedFilesWithAncestor` is not supported in git repos', | |||
|
I'm gonna approve this to unblock, but in general this feature isn't great and simply mirrors what we have done for a long time. However, it is buggy and only happens to work most of the time because it would simply run more tests than necessary. I think the ideal solution here is to make it so that a flag like this (probably with a different name?) that will do one of two things:
Do you think we could change this behavior completely? I think this would improve UX and make it less confusing which tests are run. |
|
(Approved to unblock, though) |
|
I'll merge for now, to further unblock and release a new version. We can change the behavior later and break this argument. |
* --changedFilesWithAncestor * Update git.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
i don't know why we chose to do it this way in WWW, but since we're doing it, we might want to implement the same for
git